Replace String.format with concatenation in CorrelationIdFormatter #46467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
kzander91
reviewed
Jul 20, 2025
| @@ -76,7 +76,7 @@ public final class CorrelationIdFormatter { | |||
|
|
|||
| private CorrelationIdFormatter(List<Part> parts) { | |||
| this.parts = parts; | |||
| this.blank = String.format("[%s] ", parts.stream().map(Part::blank).collect(Collectors.joining(" "))); | |||
| this.blank = "[" + parts.stream().map(Part::blank).collect(Collectors.joining(" ")) + "] "; | |||
There was a problem hiding this comment.
Why don't we at this point just use the Collectors.joining() variant with a prefix and suffix?
Suggested change
| this.blank = "[" + parts.stream().map(Part::blank).collect(Collectors.joining(" ")) + "] "; | |
| this.blank = parts.stream().map(Part::blank).collect(Collectors.joining(" ", "[", "] ")); |
|
@OrangeDoro I'm sorry but we're a small team and we aren't able to respond to requests such as yours. |
|
Thanks for the PR and the additional suggestion @kzander91. As this code is called pretty infrequently I don't think we have any performance issues. The other changes are pretty subjective and as such I'd prefer to leave things as they are. |
philwebb
added
the
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
String.format()with string concatenation for simple text joining inCorrelationIdFormatter.Changes:
"[" + ... + "] "instead ofString.format("[%s] ", ...)in constructorMotivation:
This change maintains identical functionality while using a more efficient approach for basic string joining.